Re: [PATCH 2/9] crypto: qce: Add register defines

From: Srinivas Kandagatla
Date: Fri Apr 04 2014 - 05:23:32 EST

Minor nitpicks.

On 03/04/14 17:17, Stanimir Varbanov wrote:
+#define REQ_SIZE 17 /* bit 20-17 */

I would have defined macros like this with _SHIFT at the end, something like this:

#define REQ_SIZE_SHIFT 17

+#define REQ_SIZE_MASK (0xf << REQ_SIZE)
You could possibly use GENMASK macro for this, its much readable, in *some cases* it could reduce few more lines in header too.

#define REQ_SIZE_MASK GENMASK(20, 17)

My comments are equally applicable to most macros in this header file.

Linaro Qualcomm Landing Team. â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at