Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

From: Alexandre Oliva
Date: Fri Apr 04 2014 - 10:35:57 EST


On Apr 3, 2014, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:

> On 3 April 2014 18:10, Alexandre Oliva <oliva@xxxxxxx> wrote:
>> FWIW, the same mistake is present in at32.

> I will check others as well now :)

Thanks!

>> Reverting all the changes to loongson2_cpufreq.c in 652ed95d5fa makes
>> cpufreq work again, as opposed to printing nan% in all cpufreq stats in
>> cpufreq-info's output, and freezing shortly thereafter.

> You must have a look at this:

> https://lkml.org/lkml/2014/4/2/426 : [PATCH] MIPS/loongson2_cpufreq:
> fix CPU clock rate setting

Thanks, I confirm that patch is enough to avoid the symptoms I'd
described.

--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/