Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

[Wolfram Sang]

On Fri, Apr 04, 2014 at 04:28:55PM +0200, Marek Vasut wrote:
> On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote:
> > Add dma support for i2c. This function depend on DMA driver.
> > You can turn on it by write both the dmas and dma-name properties in dts
> > node.
> > 
> > Signed-off-by: Yuan Yao <yao.yuan@xxxxxxxxxxxxx>
> 
> [...]
> 
> Since you will be fixing that superfluous return 0; (I actually wonder, did you 
> really test the driver at all before submitting it?) ...

Good question. @Yuan: Next time, please state what tests you did with
the new version of the driver.

Attachment: signature.asc
Description: Digital signature