Re: [tip:x86/reboot] [PATCH] x86: Try the BIOS reboot method before the PCI reboot method

[Ingo Molnar]

* Li, Aubrey <aubrey.li@xxxxxxxxxxxxxxx> wrote:

> <cc to adam>
> 
> On 2014/4/4 16:00, Ingo Molnar wrote:
> > 
> >>
> >> [PATCH] x86: Try the BIOS reboot method before the PCI reboot method
> > 
> > So, JFYI, I have put this into x86/reboot to get it tested, but it's 
> > not queued up for upstream yet until there's concensus.
> > 
> > (Steve testing it wouldn't hurt either.)
> > 
> > Thanks,
> > 
> > 	Ingo
> 
> The change is originated from the following bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=70931
> 
> The system will hang after BIOS or TRIPLE if it doesn't work, that's 
> why I added CF9 before BIOS and TRIPLE.
> 
> Adam may want to try this change to see if reboot works on his DELL 
> Venue 8 Pro.
> 
> I don't think there is enough justification to revert the patch. 
> [...]

'Breaks a box' is more than enough justification to revert a patch...

You can try to fix boxes, but only if you can do it without breaking 
others.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/