Re: [PATCH 2/4] perf, kmem: Utilize the new generic cpunode_map

[Jiri Olsa]

On Mon, Mar 31, 2014 at 10:42:30PM -0400, Don Zickus wrote:

SNIP

> > > -#define PATH_SYS_NODE	"/sys/devices/system/node"
> > > -
> > > -static int init_cpunode_map(void)
> > > -{
> > > -	FILE *fp;
> > > -	int i, err = -1;
> > > -
> > > -	fp = fopen("/sys/devices/system/cpu/kernel_max", "r");
> > 
> > so the factored code from previous patches now reads
> > the max_cpu_num value from:
> >   /sys/devices/system/cpu/possible
> > 
> > is this intentional?
> 
> Yeah, I was trying to save bits.  No need to allocate for 5100 cpus when
> only 128 are used.
> 
> > 
> > I think we want to have separate patches for code changes
> > and for changing the file with some comment.
> 
> So you want me to split the previous patch into two.  One for code
> movement, the other for the path change?

I think thats the proper way.. single logic change for patch

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/