Re: linux-next: Tree for Apr 1 (netfilter)

[David Miller]

From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Date: Sun, 6 Apr 2014 15:50:04 +0200

> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>
>>> on x86_64:
>>>
>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>
>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>
>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>> sized array elements.
> 
> Anyone with a suggestion?
> 
> Please note this is now in Linus' tree, possibly crashing people's boxes...

I took in the version of the fix I didn't like via Pablo for
now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/