Re: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

[Arnd Bergmann]

On Monday 07 April 2014 14:32:20 Mike Looijmans wrote:
> On 04/07/2014 02:25 PM, Arnd Bergmann wrote:
> 
> Judging from the kernel output, regulator_get_optional returns -ENODEV if the 
> supply wasn't found.
> 
> Maybe the API is confusing (or wrong?) here.
> 
> If you change the code as per your suggestion, the SD will not work unless you 
> explicitly assign supplies. And judging from what I've seen so far, I am the 
> first to have ever attached a power supply to this controller...

It's certainly not very "optional" if it returns an error here.

You could try to special-case the "-ENODEV" return here, but I think it
would be better to change the regulator interface to be less confusing.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/