Re: [PATCH 1/2] mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free

[Grygorii Strashko]

On 04/04/2014 04:15 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 04-04-2014 17:40, Grygorii Strashko wrote:
>
> > Add a resource managed devm_mdiobus_alloc()/devm_mdiobus_free()
> > to automatically clean up MDIO bus alocations made by MDIO drivers,
> > thus leading to simplified MDIO drivers code.
>
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> [...]
>
> > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> > index 76f54b3..fdcd6d1 100644
> > --- a/drivers/net/phy/mdio_bus.c
> > +++ b/drivers/net/phy/mdio_bus.c
> > @@ -69,6 +69,74 @@ struct mii_bus *mdiobus_alloc_size(size_t size)
> >   }
> >   EXPORT_SYMBOL(mdiobus_alloc_size);
> >
> > +static void _devm_mdiobus_free(struct device *dev, void *res)
> > +{
> > +    mdiobus_free(*(struct mii_bus **)res);
> > +}
> > +
> > +static int devm_mdiobus_match(struct device *dev, void *res, void *data)
> > +{
> > +    struct mii_bus **r = res;
>
>     Please insert an empty line after declaration.
>
> > +    if (!r || !*r) {
> > +        WARN_ON(!r || !*r);
>
>     Hm, why we need the duplicate check This condition is always true.

It can be replaced with:
	if (WARN_ON(!r || !*r))
		return 0;


I will wait for additional comments, then resend.

Regards,
- grygorii

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/