Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation
From: Axel Lin
Date: Wed Apr 09 2014 - 05:50:53 EST
2014-04-02 8:26 GMT+08:00 Axel Lin <axel.lin@xxxxxxxxxx>:
> 2014-03-08 11:55 GMT+08:00 Axel Lin <axel.lin@xxxxxxxxxx>:
>> The is_enabled implementation is wrong in some cases:
>> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
>> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
>> So is_enabled callback will always return false in this case.
>> Fix the logic to compare the register value with info->enable rather than
>> info->enable_mask.
>>
>
> Hi Chris,
> Would you pick up this patch serial?
I just found Chris sent a pull request for 3.15-rc1.
So I'll resend this serial to Mark after 3.15-rc1 is out.
>
> Regards,
> Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/