Re: [PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto()

[Dan Carpenter]

On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote:
> 
> A string of goto_buf has a number followed by x or y.
> e.g. "3x" means move 3 lines down.
> The kstrtol() returns an error(-EINVAL) with this string so
> go_pos has unsigned a value of that error.
> And also "*cp" has not expected value.
> 

Good catch.  This was introduced when we changed the simple_strtoul() to
kstrtol().

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Did you find this bug by testing or through reading the code?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/