Re: [RFC PATCH 6/6] uprobes/x86: Emulate rip-relative conditional "near" jmp's

[Oleg Nesterov]

On 04/08, Jim Keniston wrote:
>
> On Mon, 2014-04-07 at 16:28 +0200, Oleg Nesterov wrote:
> >
> > It seems that 16bit condi jmp is just 0x0f + short_jump_opc_plus_0x10.
>
> Yes, but the code could use a comment to that effect.  See below.

OK, will do.

> Searching for "jump" in the AMD manual, I see that there are 3 other
> instructions that are essentially conditional branches: loop,
> loope/loopz, and loopne/loopnz.

Yes, I know, Denys already informed me privately ;)

> The offset is always 8 bits.

And thus this series can ignore them. But as I already said, I'll try
to support them later just for completeness.

> BTW, patches 2 and 3 look fine to me.

Great!

Thanks again Jim for your helpful review.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/