Re: [PATCH] ASoC: core: Fix Sparse incompatible types warning

[Mark Brown]

On Wed, Apr 09, 2014 at 01:30:47PM +0200, Lars-Peter Clausen wrote:
> On 04/09/2014 01:12 PM, Krzysztof Kozlowski wrote:
> >On Åro, 2014-04-09 at 12:57 +0200, Lars-Peter Clausen wrote:
> >>On 04/09/2014 09:21 AM, Krzysztof Kozlowski wrote:

> >>>-	buf_size = min(count, (sizeof(buf)-1));
> >>>+	buf_size = min(count, (size_t)(sizeof(buf)-1));

> >>But shouldn't the type of sizeof already be size_t?

> >Hmmm... yes it should. It looks like a false positive from Sparse so the
> >commit message should be rather "Suppress" than "Fix".

> I'm pretty sure it is a bug in sparse, we shouldn't suppress those, but
> rather fix them in sparse itself.

Either that or there's something else going on that hasn't been properly
understood.  The above just looks completely bogus.

Attachment: signature.asc
Description: Digital signature