Re: [RFC PATCH v2 0/6] uprobes/x86: fix the reprel jmp/call handling

[Jim Keniston]

On Wed, 2014-04-09 at 21:44 +0200, Oleg Nesterov wrote:
> On 04/06, Oleg Nesterov wrote:
> >
> > OK. Please see the RFC changes. Obviously not for inclusion yet. And
> > totally untested, except I verified that the test-case from 4/6 works.
> 
> Still not really tested, but seems to work.
> 
> Please see v2. All changes are minor except the s/ENOSYS/-ENOSYS/ fix.
> Please see the intediff below. I also move "Introduce sizeof_long() ..."
> to the head of this series.
> 
> Jim, I am still thinking how I can improve the commenents in 4/6 as you
> asked me, and I obviously need to write the changelogs and change "ttt"
> prefix.
> 
> Will you agree with s/ttt/branch/ ?

Yes.

> 
> Do you think the code is fine in v2 ?

Yes, except for certain comments wrt call emulation.  See my reply about
patch #4 from a few minutes ago.

Once that's resolved, I consider all your patches so far
Reviewed-by: Jim Keniston <jkenisto@xxxxxxxxxx>
and
Acked-by: Jim Keniston <jkenisto@xxxxxxxxxx>

> 
> Oleg.
...

Jim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/