Re: [RFC PATCH v2 6/6] uprobes/x86: Emulate rip-relative conditional "near" jmp's

[Denys Vlasenko]

On 04/09/2014 09:44 PM, Oleg Nesterov wrote:
> +	case 0x0f:
> +		if (insn->opcode.nbytes != 2)
> +			return -ENOSYS;
> +		/*
> +		 * If it is a "near" conditional jmp, OPCODE2() - 0x10 matches
> +		 * OPCODE1() of the "short" jmp which checks the same condition.
> +		 */

I propose:

/*
 * Near conditional jump opcodes: 0f 80..8f
 * Short conditional jump opcodes: 70..7f
 * Convert OPCODE2() to corresponding short jump opcode:
 */

> +		opc1 = OPCODE2(insn) - 0x10;
>  	default:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/