Re: [PATCH] staging: r8723au: Add missing initialization of change_inx in sort algorithm

From: Larry Finger
Date: Thu Apr 10 2014 - 14:01:35 EST


On 04/10/2014 12:46 PM, Geert Uytterhoeven wrote:
drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function âWMMOnAssocRsp23aâ:
drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: âchange_inxâ may be used uninitialized in this function

Depending on the uninitialized data on the stack, the array may not be
sorted correctly.

Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
---

Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

Geert,

Thanks for this. I wonder why my gcc on x86_64 did not flag this problem.

Larry

drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
index 0dfcfbce3b52..a4361bb93865 100644
--- a/drivers/staging/rtl8723au/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
@@ -681,7 +681,7 @@ void WMMOnAssocRsp23a(struct rtw_adapter *padapter)
inx[0] = 0; inx[1] = 1; inx[2] = 2; inx[3] = 3;

if (pregpriv->wifi_spec == 1) {
- u32 j, tmp, change_inx;
+ u32 j, tmp, change_inx = false;

/* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */
for (i = 0; i < 4; i++) {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/