Re: [PATCH 11/15] kernel:acct:spaces required

[Al Viro]

On Thu, Apr 10, 2014 at 07:54:06PM +0100, Paul McQuade wrote:
> ERROR: spaces required around that '>' (ctx:VxV)

Egads, man...

a) ERROR (in ALL CAPS, no less) according to whom?  Sure, it's nicer to
add those spaces, but do you really think that it deserves a separate
patch, especially with such a commit message?

b) AFAICS, you've posted at least 4 such one-liners to kernel/acct.c, with
commit messages that sound like "Because The Most Holy sendpatch.pl (All Praise
sendpatch.pl) Says So".  There might be some reason to split the
asm/uaccess.h -> linux/uaccess.h replacement into a separate commit, but
the rest of that?  Come on...

Trivial whitespace, etc. changes like that should be clearly marked as such
and not split beyond reasonable...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/