Re: [PATCH v2 00/14] dma: edma: Fixes for cyclic (audio) operation

From: Vinod Koul
Date: Fri Apr 11 2014 - 13:02:19 EST


On Tue, Apr 01, 2014 at 04:06:01PM +0300, Peter Ujfalusi wrote:
> Hi,
>
> This is basically a resend of the previous series:
> https://lkml.org/lkml/2014/3/13/119
> with removed ASoC patches (most of them are applied already).
>
> Changes since v1:
> - ASoC patches removed
> - Comments from Andriy Shevchenko addressed
> - patch added to fix cases when src/dst_maxburst is set to 0
>
> Adding support for DMA pause/resume
> Possibility to select non default event queue/TC for cyclic (audio) dma
> channels: all devices using the eDMA via dmaengine was assigned to the default
> EQ/TC (mmc, i2c, spi, etc, and audio). This is not optimal from system
> performance point of view since sharing the same EQ/TC can cause latency spikes
> for cyclic channels (long DMA transfers for MMC for example).
>
> While debugging the edma to get things sorted out I noticed that the debug was
> too verbose and the important information was hidden even when the we did not
> asked for verbose dmaengine debug.
> I have included some debug cleanups for the edma dmaengine driver also.
>
> Regards,
> Peter
> ---
> Peter Ujfalusi (14):
> platform_data: edma: Be precise with the paRAM struct
> dma: edma: Correct the handling of src/dst_maxburst == 0
> dma: edma: Add support for DMA_PAUSE/RESUME operation
> dma: edma: Set DMA_CYCLIC capability flag
> arm: common: edma: Select event queue 1 as default when booted with DT
> arm: common: edma: Save the number of event queues/TCs
> arm: common: edma: API to request non default queue for a channel
> DMA: edma: Use different eventq for cyclic channels
> dma: edma: Implement device_slave_caps callback
> dma: edma: Simplify direction configuration in edma_config_pset()
> dma: edma: Reduce debug print verbosity for non verbose debugging
> dma: edma: Prefix debug prints where the text were identical in prep
> callbacks
> dma: edma: Add channel number to debug prints
> dma: edma: Print the direction value as well when it is not supported

Okay I have noticed lots of folks are using dma: which IMO isn't right here,
would prefer folks to use the right subsystem name, so dmaengine: xxxx would be
right subject line :)

--
~Vinod
>
> arch/arm/common/edma.c | 34 +++++++++++++-
> drivers/dma/edma.c | 96 +++++++++++++++++++++++++++++---------
> include/linux/platform_data/edma.h | 20 ++++----
> 3 files changed, 119 insertions(+), 31 deletions(-)
>
> --
> 1.9.1
>

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/