Re: ftrace: reading set_graph_notrace returns "#### all functions enabled ####"

[Steven Rostedt]

On Fri, 11 Apr 2014 14:24:17 -0400
Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> wrote:

> Hi,
> 
> I report a minor issue of set_graph_notrace.
> The default value of set_graph_notrace is void (so no function is excluded,)
> but when we read the file, we get "#### all functions enabled ####" like below:
> 
>   [root@test tracing]# echo "" > set_graph_notrace
>   [root@test tracing]# cat set_graph_notrace
>   #### all functions enabled ####
> 
> This does not happen for set_ftrace_notrace:
> 
>   [root@test tracing]# echo "" > set_ftrace_notrace
>   [root@test tracing]# cat set_ftrace_notrace
>   [root@test tracing]#
> 
> This is not critical but confusing, so it would be nice if fixed.

Ah, I would say they both are wrong. The set_graph_notrace is rather
new, and probably copied and pasted incorrectly.

But having nothing printed may not be the best thing to show. I think
both should be switched to

#### no functions disabled ####

But this can be done in my 3.16 queue.

Thanks for the report,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/