Re: [PATCH 1/1] FS: Add generic data flush to fsync

From: Fabian Frederick
Date: Fri Apr 11 2014 - 17:04:32 EST


On Fri, 11 Apr 2014 00:45:22 -0700
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Fri, Apr 11, 2014 at 06:52:42AM +0200, Fabian Frederick wrote:
> > Currently, there's no generic HW flush management support in kernel.
> > Only 7 filesystems have their own way to manage the barrier flag.
> >
> > This patch adds MS_BARRIER in sb_flags and conditionnaly issues the flush
> > in generic_file_fsync.
>
> Please don't add a binary mount option for something thast already is a
> text option in many filesystems. We can actually enable/disable cache
> flushes at the block device level, so I think this can be
> unconditional.

Ok, that would mean 'older' filesystems -without barrier flag-
to call generic_file_fsync would result in a flush but ext4 without journal
also calls it ; maybe with nobarrier and I'm not sure it's the only case.
How can I deal with this problem ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/