Re: [PATCH] USB: cdc-acm: fix double usb_autopm_put_interface() in acm_port_activate()

From: Oliver Neukum
Date: Sat Apr 12 2014 - 14:39:23 EST


On Sat, 2014-04-12 at 02:10 +0400, Alexey Khoroshilov wrote:
> If acm_submit_read_urbs() fails in acm_port_activate(), error handling
> code calls usb_autopm_put_interface() while it is already called
> before acm_submit_read_urbs(). The patch reorganizes error handling code
> to avoid double decrement of USB interface's PM-usage counter.
>
> Found by Linux Driver Verification project (linuxtesting.org).

Nice catch.

> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
Acked-by: Oliver Neukum <oliver@xxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/