Re: [RFC PATCH v2 6/6] KVM: emulate: remove memopp and rip_relative

[Paolo Bonzini]

Il 10/04/2014 20:03, Bandan Das ha scritto:
>  	/* Fields above regs are cleared together. */

This comment is not accurate anymore after patch 4.  Since you're fixing 
it, please add another comment saying where the cleared fields start, too.

> +	ctxt->memop.addr.mem.ea = (u32)ctxt->memop.addr.mem.ea;

This is missing "if (ctxt->ad_bytes != 8)".

> +	if (rip_relative)
> +		ctxt->memop.addr.mem.ea += ctxt->_eip;

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/