Re: [PATCH v3 1/5] x86: initialize secondary CPU only if master CPU will wait for it

[Ingo Molnar]

* Igor Mammedov <imammedo@xxxxxxxxxx> wrote:

>  	/*
> +	 * wait for ACK from master CPU before continuing
> +	 * with AP initialization
> +	 */
> +	cpumask_set_cpu(cpu, cpu_initialized_mask);
> +	while (!cpumask_test_cpu(cpu, cpu_callout_mask))
> +		cpu_relax();

> +	/*
> +	 * wait for ACK from master CPU before continuing
> +	 * with AP initialization
> +	 */
> +	cpumask_set_cpu(cpu, cpu_initialized_mask);
> +	while (!cpumask_test_cpu(cpu, cpu_callout_mask))
> +		cpu_relax();

That repetitive pattern could be stuck into a properly named helper 
inline function.

(Also, before the cpumask_set_cpu() we should probably do a WARN_ON() 
if the bit is already set.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/