Re: [PATCH v3 3/5] x86: fix list corruption on CPU hotplug

[Ingo Molnar]

* Igor Mammedov <imammedo@xxxxxxxxxx> wrote:

> On Mon, 14 Apr 2014 11:19:54 +0200
> Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> 
> > 
> > * Igor Mammedov <imammedo@xxxxxxxxxx> wrote:
> > 
> > > currently if AP wake up is failed, master CPU marks AP as not present
> > > in do_boot_cpu() by calling set_cpu_present(cpu, false).
> > > That leads to following list corruption on the next physical CPU
> > > hotplug:
> > 
> > Shouldn't this fix precede the main change to the smp bootup logic?
> > 
> > Can this bug trigger with current upstream kernels?
> That's not impossible, tests showed that with current kernel there will
> be other problems due wild AP running around.
> 
> I'll reorder patch anyway.

So, could you please first make sure that with only the fixes applied 
there's no problems left?

Only then should we apply the patch that adds/tweaks the timeout/etc.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/