Re: [PATCH 2/3] ARM : kdump : add arch_crash_save_vmcoreinfo

[Liu hua]

ä 2014/4/14 19:37, Will Deacon åé:
> On Thu, Mar 27, 2014 at 08:00:39AM +0000, Liu Hua wrote:
>> For vmcore generated by LPAE enabled kernel, user space
>> utility such as crash needs additional infomation to
>> parse.
>>
>> So this patch add arch_crash_save_vmcoreinfo as what PAE enabled
>> i386 linux does.
> 
> Looks sensible to me:
> 
>   Reviewed-by: Will Deacon <will.deacon@xxxxxxx>
> 
> Will

Hi Will,

Thanks to you reply. How about the first one of the patch
series named "[PATCH 1/3] ARM : kdump : Add LPAE support".

Now the ARM linux will simply return error when parse an
LPAE enabled kernel, becausethe commit 4b3bf7ae provide
zero vmcore_elf64_check_arch(). So if we want parse LPAE
enabled kernel, we need that one.

Thanks,
Liu Hua
> 
>> Signed-off-by: Liu Hua <sdu.liu@xxxxxxxxxx>
>> To: Russell King <linux@xxxxxxxxxxxxxxxx>
>> Cc: Stephen Warren <swarren@xxxxxxxxxx> 
>> Cc: Will Deacon <will.deacon@xxxxxxx>
>> Cc: Vijaya Kumar K <vijay.kilari@xxxxxxxxx>
>> Cc: <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
>> Cc: <linux-kernel@xxxxxxxxxxxxxxx>
>> Cc: <kexec@xxxxxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm/kernel/machine_kexec.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
>> index f0d180d..8cf0996 100644
>> --- a/arch/arm/kernel/machine_kexec.c
>> +++ b/arch/arm/kernel/machine_kexec.c
>> @@ -184,3 +184,10 @@ void machine_kexec(struct kimage *image)
>>  
>>  	soft_restart(reboot_entry_phys);
>>  }
>> +
>> +void arch_crash_save_vmcoreinfo(void)
>> +{
>> +#ifdef CONFIG_ARM_LPAE
>> +	VMCOREINFO_CONFIG(ARM_LPAE);
>> +#endif
>> +}
>> -- 
>> 1.9.0
>>
>>
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/