Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition

[Paul E. McKenney]

On Mon, Apr 14, 2014 at 12:19:31PM -0400, Pranith Kumar wrote:
> Hi Paul,
> 
> On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
> <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> > On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
> >> remove duplicate definition of extern resched_cpu
> >>
> >> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> >
> > Hello, Pranith,
> >
> > When I apply this patch I get the following:
> >
> > /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: In function ârcu_implicit_dynticks_qsâ:
> > /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: error: implicit declaration of function âresched_cpuâ [-Werror=implicit-function-declaration]
> > /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: At top level:
> > /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:1009:13: warning: conflicting types for âresched_cpuâ [enabled by default]
> > /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: note: previous implicit declaration of âresched_cpuâ was here
> >
> > This failed in under number of different Kconfig setups, the .config file
> > for one of them is attached.
> >
> > So this declaration really is needed.  Just out of curiosity, what led
> > you to believe that it could be removed?
> >
> 
> That is strange. The patch removes a duplicate declaration of
> resched_cpu (on lines 768, 954) of the file kernel/rcu/tree.c of the
> latest git.
> 
> The patch compiles fine here with the latest tip of the git tree.
> 
>   CC      kernel/rcu/tree.o
> 
> Can you please check if your tree.c has two declarations for resched_cpu?

Ah, your patch didn't apply, so I hand-applied it, and removed the first
declaration rather than the second one.  Trying it again.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/