Re: [PATCH] seccomp: fix populating a0-a5 syscall args in 32-bit x86 BPF

[David Miller]

From: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
Date: Mon, 14 Apr 2014 13:13:45 -0700

> I think this description is wrong.  (unsigned long *) &sd->args[1] is
> the right location, at least on 32-bit little-endian architectures.

It absolutely is not.

The thing is a u64, and we must respect that type in a completely
portable way.

Daniel's change is %100 correct, portable, and doesn't have any
ugly ifdef crap.

If you want to optimize this, and potentially break it again, do
it in the next merge window not now.

I'm going to apply Daniel's patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/