Re: Hardware dependencies in Kconfig

From: Jean Delvare
Date: Tue Apr 15 2014 - 03:27:52 EST


Hi Greg,

On Mon, 14 Apr 2014 21:53:34 -0700, Greg KH wrote:
> On Mon, Apr 14, 2014 at 03:59:11PM -0400, Josh Boyer wrote:
> >
> > Maybe I'm overly grumpy. Still, it's frustrating to see Kconfig
> > entries that clearly say "blahblah found on foo ARM chip" in the help
> > with no "depends on ARM" (not meaning to pick on ARM). I would like
> > to think there is some balance that could be found here.
>
> Yes, that would make me grumpy, perhaps a few developers could be
> auditing the new Kconfig items of every kernel around -rc3 timeframe to
> ensure that they don't do stuff like this...

It's the reviewer's job to refuse new drivers with bad Kconfig
descriptions in the first place. This must happen as early as possible
in the chain. By -rc3 it's way too late, all kernel developers and
distributions have already moved to the new kernel so they have already
answered the n/m/y question for all new entries.

--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/