Re: [PATCH] mfd: mc13xxx-core: Initialize the lock prior to using it

[Russell King - ARM Linux]

On Tue, Apr 15, 2014 at 07:43:10PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> 
> After request_threaded_irq() is called there is a chance that an interrupt
> may occur before the 'mc13xxx->lock' is initialized, which will trigger a kernel
> warning.

I'd suggest... "which will trigger a kernel oops" because that's what
you got - it killed the IRQ thread, which then caused a few other
problems along the way.

> In order to prevent that, move the initialization of 'mc13xxx->lock' prior to
> requesting the interrupts.
> 
> Suggested-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>

Patch looks good, and should fix the reported issue... so with the above
description fixed,

Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>

Thanks.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/