Re: [PATCH 08/28] nios2: MMU Fault handling

[Ezequiel Garcia]

On Apr 24, Ley Foon Tan wrote:
> On Tue, Apr 22, 2014 at 10:30 PM, Ezequiel Garcia
> <ezequiel.garcia@xxxxxxxxxxxxxxxxxx> wrote:
> > Hello Ley Foon,
> >
> > On Apr 18, Ley Foon Tan wrote:
> >> +
> >> +bad_area_nosemaphore:
> >> +     /* User mode accesses just cause a SIGSEGV */
> >> +     if (user_mode(regs)) {
> >
> > I found that it's useful to add some printing here, just as ARM
> > does. I carry this patch on my kernel:
> >
> > +               printk(KERN_INFO "%s: unhandled page fault (%d) at 0x%08lx, cause %ld\n",
> > +                      current->comm, SIGSEGV, address, cause);
> > +               show_regs(regs);
> >
> > Do you think we could do something like it? Maybe with a compile time option?
> Yes, this is useful debug message. I can add this.
> Prefer not to add new compile time option, I think this shouldn't
> happen frequently.

No, it shouldn't happen frequently. You can take a look at what ARM does.
They use a DEBUG_USER compile-time option, much more complex than my silly
proposal.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/