RE: [PATCH] staging: comedi: addi_apci_1564: separate from addi_common.c

[Hartley Sweeten]

On Thursday, April 24, 2014 12:19 AM, Chase Southwood wrote:
> Using the addi-data "common" code in addi_apci_1564 introduces a lot of
> bloat.  By separating this driver off from addi_common.c, a lot of the
> common code can be stripped out.  This patch copies the code over from
> addi_common.c, and removes the #include of the file.  The auto_attach
> function from the common code replaces the one that was previously in this
> driver, though renamed to that it stays within the namespace associated
> with this driver, and the detach function has been renamed for this reason
> as well.
>
> Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx>
> Cc: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Ian Abbott <abbotti@xxxxxxxxx>
> ---
> Compile tested only.

Looks good.

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/