Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to handle child nodes

[Jonathan Cameron]

On 25/04/14 16:46, Doug Anderson wrote:
> Naveen,
>
> Thanks for sending this.  Given that Jonathan Cameron was involved in
> the previous discussion, it probably would have been wise to include
> him on the CC list.
In my case, don't worry too much as I have linux-iio coming into exactly
the same place in my inbox. Doug is correct that it is generally a good
idea unless someone has asked you not to.
> On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi
> <ch.naveen@xxxxxxxxxxx> wrote:
> > From: Naveen Krishna Ch <ch.naveen@xxxxxxxxxxx>
> >
> > Using pdev->dev with device_for_each_child() would iterate over all
> > of the children of the platform device and delete them.
> > Thus, causing crashes during module unload.
> >
> > We should be using the indio_dev->dev structure for
> > registering/unregistering child nodes.
> >
> > Signed-off-by: Naveen Krishna Ch <ch.naveen@xxxxxxxxxxx>
> > ---
> > This change was tested on top of
> >     https://lkml.org/lkml/2014/4/21/481 from Doug.
> >
> >   drivers/iio/adc/exynos_adc.c |    6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
>
> Reported-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
Applied to the fixes-togreg branch of iio.git

Thanks,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/