Re: [PATCH 1/2] mfd: max14577: Fix IRQ handling after resume if this is not a wakeup source

[Lee Jones]

> During suspend the IRQ should be disabled even if this is not a wakeup
> source. This is a proper way of fixing the IRQ handling issue during
> resume (IRQ handler fails because I2C bus did not resume yet).
> 
> When device is suspended and max14577 interrupt is signaled the irq chip
> will try to handle it regardless of wakeup source. Device could be woken
> up by different IRQ but still the IRQ handler will try to read the
> registers over I2C bus and fail because I2C bus won't be ready yet:
> 	max14577 2-0025: Failed to read IRQ status: -5
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
>  drivers/mfd/max14577.c | 29 +++++++++++++----------------
>  1 file changed, 13 insertions(+), 16 deletions(-)

It's pretty worrying that these two patches are so alike and they
actually change different files. Is there any way we can unify more of
the code?

Patch applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/