Re: [PATCH V5 12/12] ACPI: introduce .handle_children flag for acpi scan handler

[Rafael J. Wysocki]

On 4/28/2014 4:07 AM, Zhang Rui wrote:
> On Mon, 2014-04-28 at 00:26 +0200, Rafael J. Wysocki wrote:
> > On Tuesday, April 08, 2014 12:06:59 AM Zhang Rui wrote:
> > > For some devices with scan handler attached, their children devices
> > > are enumerated by the scan handler, indirectly.
> > This isn't the case really.  They are enumerated by bus controller drivers
> > for the buses they are on.
> that's what I mean by saying "indirectly". :)
>
> > > In this case, we do not want to enumerate the children devices in
> > > acpi scan code explicitly.
> > >
> > > Thus a new flag .handle_children is introduced in this patch.
> > >
> > > For scan handlers with this flag set, we will do default enumeration neither
> > > for the attached devices nor for the children of the attached devices.
> > I'm not sure if that is the right approach.  I would prefer that to be
> > handled in a more fine-graind manner, like a flag per device ID or something
> > similar?
> hmmm, how about this,
> first, keep the device->flags.no_child_enumeration flag introduced in
> this patch
> second, set the flag explicitly, for specified devices, in the scan
> handler .attach() function.

But then it could simply clear the platform_id flag for them, couldn't it?

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/