Re: [PATCH 2/5] uprobes/x86: Add is_64bit_mm(), kill validate_insn_bits()

[Srikar Dronamraju]

* Oleg Nesterov <oleg@xxxxxxxxxx> [2014-04-19 19:01:51]:

> 1. Extract the ->ia32_compat check from 64bit validate_insn_bits()
>    into the new helper, is_64bit_mm(), it will have more users.
> 
>    TODO: this checks is actually wrong if mm owner is X32 task,
>    we need another fix which changes set_personality_ia32().
> 
>    TODO: even worse, the whole 64-or-32-bit logic is very broken
>    and the fix is not simple, we need the nontrivial changes in
>    the core uprobes code.
> 
> 2. Kill validate_insn_bits() and change its single caller to use
>    uprobe_init_insn(is_64bit_mm(mm).
> 
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/