Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes

[Barry Song]

2014-04-28 22:52 GMT+08:00 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>:
> On Mon, Apr 28, 2014 at 10:37:09AM -0400, Matt Porter wrote:
>> The "fix" is tested against bcm281xx and bcm21664 as that is what the
>> l2c cleanup breaks in -next. As mentioned, I don't have the sirfsoc h/w
>> so this first attempt at a fix also breaks their platform. It can be
>> addressed by adding those platform specific compatibles back to the dts,
>> of course.
>>
>> I'd much prefer that the sirfsoc folks fix this...it's going to break
>> other platforms in a multi v7 build.
>
> Well, it's about time we got rid of this from platform specific code
> anyway, taking it away from platform maintainers to mess around with.
> So that's what I'm doing.
>
> It's worth noting that if you build a single zImage with exynos also
> enabled, then you also end up with an unconditional call from that
> code to l2x0_of_init() with it's own magic numbers - and that applies
> before my changes.
>
> So let's fix this properly and yank this crap from platform maintainers
> fingers.

i mentioned dropping specific dts compatible prop will break non-csr
platforms in the mail thread "ARM: prima2: remove L2 cache size
override" and i said i was going to send v2. you said you need it
before rc6. now it has been sent, but i am sorry it is not against
next-20140424.

>
> --
> FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
> improving, and getting towards what was expected from it.

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/