Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c

From: Ian Abbott
Date: Thu May 01 2014 - 05:02:36 EST


On 2014/04/30 06:34 PM, Raghavendra Ganiga wrote:
> This is a patch to fix coding style
> warnings found by the checkpatch.pl tool
>
> Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@xxxxxxxxx>
> ---
> drivers/staging/comedi/comedi_fops.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index acc8019..a62d639 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,15 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> s = &dev->subdevices[cmd->subdev];
>
> if (s->type == COMEDI_SUBD_UNUSED) {
> - dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> + dev_dbg(dev->class_dev, "%d not valid subdevice\n",
> + cmd->subdev);
> return -EIO;
> }
>
> if (!s->do_cmd || !s->do_cmdtest || !s->async) {
> dev_dbg(dev->class_dev,
> - "subdevice %d does not support commands\n", cmd->subdev);
> + "subdevice %d does not support commands\n",
> + cmd->subdev);
> return -EIO;
> }

(I think this is "PATCH v2".)

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/