Re: [PATCH] staging: rtl8723au: fix potential leak in update_bcn_wps_ie()

[Mateusz Guzik]

On Thu, May 01, 2014 at 01:57:27PM +0200, Christian Engelmayer wrote:
> Fix a potential leak in the error path of function update_bcn_wps_ie().
> Make sure that allocated memory for 'pbackup_remainder_ie' is freed
> upon return. Detected by Coverity - CID 1077718.
> 

        if (remainder_ielen > 0) {
                pbackup_remainder_ie = kmalloc(remainder_ielen, GFP_ATOMIC);
                if (pbackup_remainder_ie)
                        memcpy(pbackup_remainder_ie, premainder_ie,
                               remainder_ielen);
        }

        pwps_ie_src = pmlmepriv->wps_beacon_ie;
        if (pwps_ie_src == NULL)
                return;


Maybe just check pwps_ie_src earlier?

-- 
Mateusz Guzik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/