Re: [PATCH 1/1] mm/memcontrol.c: remove NULL assignment on static

[Johannes Weiner]

On Sat, Apr 26, 2014 at 10:50:31AM +0200, Fabian Frederick wrote:
> static values are automatically initialized to NULL
> 
> Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
>  mm/memcontrol.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 29501f0..6e38542 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -80,7 +80,7 @@ int do_swap_account __read_mostly;
>  #ifdef CONFIG_MEMCG_SWAP_ENABLED
>  static int really_do_swap_account __initdata = 1;
>  #else
> -static int really_do_swap_account __initdata = 0;
> +static int really_do_swap_account __initdata;
>  #endif
>  
>  #else

I actually like how this makes the 1 vs. 0 more obvious in this case,
even though it's not technically necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/