Re: [PATCH] ARM: tegra: add Tegra Note 7 device tree

[Stephen Warren]

On 05/01/2014 01:10 AM, Alexandre Courbot wrote:
> Tegra Note 7 is a consumer tablet embedding a Tegra 4 SoC with 1GB RAM
> and a 720p panel.
> 
> The following features are enabled by this device tree: UART, eMMC, USB
> (needs external power), PMIC, backlight, DSI panel, keys.
> 
> SD card, HDMI, charger, self-powered USB, audio, wifi, bluetooth are not
> yet supported but might be by future patches (likely in that order).

> diff --git a/arch/arm/boot/dts/tegra114-tn7.dts b/arch/arm/boot/dts/tegra114-tn7.dts

> +	chosen {
> +		/* TN7's bootloader's arguments need to be overridden */
> +		bootargs = "console=ttyS0,115200n8 console=tty1 gpt cma=128M fbcon=rotate:2";

Do we still need the cma argument at all now? The default is now 64M in
tegra_defconfig, and 128M seems quite large.

> +	host1x@50000000 {
> +		hdmi@54280000 {
> +			status = "okay";
> +
> +			hdmi-supply = <&vdd_5v0_hdmi>;
> +			vdd-supply = <&vdd_3v3_hdmi>;
> +			pll-supply = <&vdd_1v05_pll>;
> +
> +			nvidia,ddc-i2c-bus = <&hdmi_ddc>;
> +			nvidia,hpd-gpio =
> +				<&gpio TEGRA_GPIO(N, 7) GPIO_ACTIVE_HIGH>;
> +		};

If HDMI doesn't work yet (per commit description), should we leave it
out of the DT for now?

> +	serial@70006300 {
> +		status = "okay";
> +	};

Is there actually an accessible UART on the board? I guess this is for
people lucky enough to have internal boards with the debug connector. If
so, this is probably fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/