Re: [PATCH 0/2] arm64: TLB flush issues

From: Mark Salter
Date: Fri May 02 2014 - 11:51:33 EST


On Fri, 2014-05-02 at 16:30 +0100, Steve Capper wrote:
> On Fri, May 02, 2014 at 11:20:33AM -0400, Mark Salter wrote:
> > As explained in more detail in the second patch, I have observed a soft
> > lockup under some loads. These lockups were in flush_tlb_kernel_range()
> > which was looping through a very large address range. While looking into
> > this, I also noticed the flush routines in tlb.S were not properly
> > handling pages larger than 4k. This is corrected in the first patch.
> > The second patch limits the loop size for the flush_tlb_[kernel_]range
> > functions. It uses an arbitrary constant to limit the loop, but it
> > would be better if it were based on actual tlb size or some other
> > heuristic.
> >
> > Mark Salter (2):
> > arm64: fix unnecessary tlb flushes
> > arm64: fix soft lockup due to large tlb flush range
> >
> > arch/arm64/include/asm/tlbflush.h | 28 +++++++++++++++++++++++++---
> > arch/arm64/mm/tlb.S | 4 ++--
> > 2 files changed, 27 insertions(+), 5 deletions(-)
> >
>
> Hi Mark,
> As a heads-up, I posted this earlier today:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/252837.html
>
> Cheers,

Thanks. That takes care of the pagesize handling (my patch 1/2).


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/