Re: [RFC PATCH] regulator: virtual: Introduce a new virtual locker regulator type

[Mark Brown]

On Fri, May 02, 2014 at 09:13:39AM -0700, Doug Anderson wrote:
> On Wed, Apr 30, 2014 at 6:28 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:

> > I glanced at this briefly and couldn't really understand what it was
> > supposed to do from a quick glance but I do tend to agree that it's too
> > complex and confusing.  Quite what the virtual regulator is supposed to
> > represent or how it is used is distinctly non-obvious.

> From my understanding, there are parts internal to the SoC where
> something powered by the INT rail looks at an signal based on the ARM
> rail, or vice versa.  If the two voltages are too vastly different
> then you get into trouble.

That bit is totally clear and normal, what's not at all obvious is what
the virtual regulator is really representing and how it will be used by
software at runtime to achieve this goal.  In general introducing purely
virtual things into the device tree is not a good sign for things like
OS independence.

> Mark Brown: did the bindings above seem sane to you?  I can clean them
> up a bit and explain more:

Yes, that's one of the suggestions I proposed...

> - regulator-lock-to: A list of regulators to monitor.  If they ever
> are greater than our voltage + the corresponding "lock-within" then we
> should bump up our voltage.  We'll bump back down if/when the
> monitored regulator falls again.

This isn't a good name, there is also a common feature in hardware where
two regulators are run in parallel to deliver higher current.  The idea
is fine though.

Attachment: signature.asc
Description: Digital signature