Re: [PATCH] i2c: qup: Fix pm_runtime_get_sync usage

[Ivan T. Ivanov]

On Fri, 2014-05-02 at 20:54 -0500, Andy Gross wrote:
> This patch corrects the error check on the call to pm_runtime_get_sync.
> 
> Signed-off-by: Andy Gross <agross@xxxxxxxxxxxxxx>


Reviewed-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx>

> ---
>  drivers/i2c/busses/i2c-qup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
> index 1b4cf14..2a5efb5 100644
> --- a/drivers/i2c/busses/i2c-qup.c
> +++ b/drivers/i2c/busses/i2c-qup.c
> @@ -479,7 +479,7 @@ static int qup_i2c_xfer(struct i2c_adapter *adap,
>  	int ret, idx;
>  
>  	ret = pm_runtime_get_sync(qup->dev);
> -	if (ret)
> +	if (ret < 0)
>  		goto out;
>  
>  	writel(1, qup->base + QUP_SW_RESET);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/