Re: [PATCH] staging/lustre: Replace jobid acquiring with per node setting

[Greg Kroah-Hartman]

On Sat, May 03, 2014 at 11:08:36PM -0400, Oleg Drokin wrote:
> Hello!
> 
> On May 3, 2014, at 10:33 PM, Greg Kroah-Hartman wrote:
> >> I don't think I saw complaints about proc files, the complaints I saw were mostly about
> >> reading env variables directly and the like so that was the focus of this patch.
> >> Did I miss some side discussion? Any pointers?
> > No, no side discussion, the proc files need to be removed / fixed before
> > the code can be merged to the "proper" part of the kernel tree.
> 
> So, what's broken about them then?
> It's not like there are no files in proc or that lustre-proc files are causing some
> sort of breakage (at least not anymore after that recent patch).

The rule of not adding new proc files that do not relate to processes,
has been around for over a decade now, since 2.6.0 came out.

Please use sysfs instead, you can put your files in /sys/fs/lustre/ and
keep them to "one-value-per-file" files and document them in
Documentation/ABI/

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/