Re: [rfc][patch] perf,tools: Remove test_attr_* muck from perf.h

[Jiri Olsa]

On Fri, May 02, 2014 at 01:52:01PM +0200, Peter Zijlstra wrote:
> On Thu, May 01, 2014 at 08:35:05PM +0200, Jiri Olsa wrote:
> > On Thu, May 01, 2014 at 10:27:30AM +0200, Peter Zijlstra wrote:
> > > Hi,
> > > 
> > > I occasionally build the odd program against raw perf and use perf.h for
> > > this.
> > > 
> > > Now I find that no longer works because of:
> > > 
> > > 52502bf201a85 ("perf tests: Add framework for automated perf_event_attr tests")
> > > 
> > > So revert the hunk touching on perf.h.
> > 
> > But but but, then you'll brake attr tests
> > 
> > > 
> > > Also, it seems to be for snake shit only, and snakes stink, except on a
> > > plane :-)
> > 
> > wanna get to lwn quotes page, huh? ;)
> > 
> > any details about the breakage? maybe we could find some
> > way to make you happy and keep the snake shit in place
> 
> linux-2.6/tools/perf# gcc -o perf_bug perf_bug.c
> /tmp/cclObJsz.o: In function `sys_perf_event_open':
> perf_bug.c:(.text+0x48): undefined reference to `test_attr__enabled'
> perf_bug.c:(.text+0x72): undefined reference to `test_attr__open'
> collect2: error: ld returned 1 exit status
> 
> Initially perf.h was meant to have just the syscall wrapper and few
> system level defines (like the membars etc..)
> 
> But now its grown all kinds of gunk outside of that.
> 
> So ideally we'd split the thing into two files, one which is a
> stand-alone syscall wrapper + system utils things and one which includes
> the former and adds all the perf (tool, not kernel) gunk on.
> 
> I see all sorts of extern perf_{host,guest} things and util/target.h
> includes.. that all should definitely move elsewhere.

sounds good, I'll prepare something along those lines

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/