Re: [PATCH 20/27] ACPICA: Tables: Fix invalid pointer accesses in acpi_tb_parse_root_table().

From: Josh Boyer
Date: Mon May 05 2014 - 08:42:51 EST


On Mon, May 5, 2014 at 12:23 AM, Zheng, Lv <lv.zheng@xxxxxxxxx> wrote:
> Hi, Rafael
>
>> From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi-owner@xxxxxxxxxxxxxxx] On Behalf Of Rafael J. Wysocki
>> Sent: Monday, May 05, 2014 8:43 AM
>>
>> On Saturday, May 03, 2014 08:59:14 AM Josh Boyer wrote:
>> > On Tue, Apr 29, 2014 at 10:05 PM, Lv Zheng <lv.zheng@xxxxxxxxx> wrote:
>> > > The commit of back porting Linux XSDT validation mechanism has introduced
>> > > a regreession:
>> > > Commit: 671cc68dc61f029d44b43a681356078e02d8dab8
>> > > Subject: ACPICA: Back port and refine validation of the XSDT root table.
>> > > There is a pointer still accessed after unmapping.
>> > >
>> > > This patch fixes this issue. Lv Zheng.
>> > >
>> > > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=73911
>> > > Buglink: https://bugs.archlinux.org/task/39811
>> > > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
>> > > Reported-and-tested-by: Bruce Chiarelli <mano155@xxxxxxxxx>
>> > > Reported-and-tested-by: Spyros Stathopoulos <spystath@xxxxxxxxx>
>> > > Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx>
>> > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.14.x: 671cc68: ACPICA: Back port and refine validation of the XSDT root table.
>> >
>> > This patch should get into 3.15-rcX soon. It fixes a known regression
>> > that prevents booting on machines with AMI firmware, and that is
>> > present in 3.14 so we need it for stable as well. Rafael?
>>
>> Lv, is it safe to take this patch alone into 3.15-rc?
>
> Yes, it's safe to only take this patch to be a regression fix.

FWIW, Fedora is carrying this on top of 3.14.2 already, and people
with the impacted machines say it's working for them. So I agree it
should be safe.

Thanks to the both of you.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/