Re: [PATCH] HID: core: fix computation of the report size

[Jiri Kosina]

On Wed, 30 Apr 2014, Benjamin Tissoires wrote:

> The extra seven bits are only required when allocating the report buffer.
> We can not use those extra bytes for the length of the report in the
> generic implementation of .request because the device might (will) refuse
> the set_report command.
> This has been verified on the Atmel touchpad found on the Samsung Ativ 9
> plus, which uses hid-multitouch and HID over I2C. Without this fix, the
> device refuses to switch to the multitouch mode, and it becomes unresponsive
> from the user point of view.
> 
> Actually, this has been discussed during the initial submission of the
> commit 4fa5a7f76cc7b6ac87f57741edd2b124851d119f, see
> https://patchwork.kernel.org/patch/3621751/
> 
> Unfortunately, I completely forgot about it later.
> 
> Reported-by: Matthias Bayer <thematthiasbayer@xxxxxxxxx>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> ---
> 
> Hi Jiri,
> 
> can you schedule this fix for 3.15?
> 
> Fortunately, the device required some ACPI changes, so it was not seen at all
> in 3.13 and before. I am not sure of the status of 3.14, but it is definitively
> not working in 3.15.

Gah, indeed, a nasty bug.

Queuing for 3.15 now, thanks!

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/