Re: [perf] more perf_fuzzer memory corruption

From: Ingo Molnar
Date: Mon May 05 2014 - 13:30:03 EST



* Vince Weaver <vincent.weaver@xxxxxxxxx> wrote:

> On Mon, 5 May 2014, Peter Zijlstra wrote:
>
> > Does this one work better? Making sure all __perf_remove_from_context()
> > callers pass the right structure seems to improve things no end. My
> > machine is now happy to reboot again.
>
> Yes, I've been fuzzing this for a few hours on both my haswell and core2
> test systems and it's doing great, also survived a reboot cycle.
>
> Tested-by: Vince Weaver <vincent.weaver@xxxxxxxxx>

I wish there was a stronger tag that would credit your efforts! ...

Kudos!

> (Although often things like to crash the instant my tested-by
> e-mails clear the lkml list.)
>
> I also want to say thanks for all the work everyone has done in
> getting this analyzed and fixed.

I'm also thinking about waiting a bit before applying anything even
borderline intrusive to the perf core, to make sure there's enough
fuzz time to declare stable state (at least as far into the ABI as the
fuzzing is able to reach). Future bisection efforts could use that
kind of known-stable release.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/