Re: [PATCH v2] uprobes: fix scratch register selection for rip-relative fixups

[Denys Vlasenko]

On 05/05/2014 05:45 PM, Oleg Nesterov wrote:
> On 05/02, Denys Vlasenko wrote:
>>  static inline unsigned long *
>>  scratch_reg(struct arch_uprobe *auprobe, struct pt_regs *regs)
>>  {
>> -	return (auprobe->def.fixups & UPROBE_FIX_RIP_AX) ? &regs->ax : &regs->cx;
>> +	/* Order is important - more than one bit can be set! */
> 
> Really?
> 
> Should I remove this comment or I misread the change in riprel_analyze?

Yes, it is not true: latest code sets only one bit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/