Re: [PATCH] tty: serial: uartlite: Specify time for sending chars

[Peter Korsgaard]

>>>>> "Michal" == Michal Simek <monstr@xxxxxxxxx> writes:

Hi,

 >> > diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
 >> > index 5f90ef24d475..723a6b79cd14 100644
 >> > --- a/drivers/tty/serial/uartlite.c
 >> > +++ b/drivers/tty/serial/uartlite.c
 >> > @@ -418,14 +418,20 @@ static struct uart_ops ulite_ops = {
 >> >  #ifdef CONFIG_SERIAL_UARTLITE_CONSOLE
 >> >  static void ulite_console_wait_tx(struct uart_port *port)
 >> >  {
 >> > -	int i;
 >> >  	u8 val;
 >> > +	unsigned long timeout;
 >> 
 >> >  	/* Spin waiting for TX fifo to have space available */
 >> > -	for (i = 0; i < 100000; i++) {
 >> 
 >> It would be good to add a note about the slow jtag variant here.

 > What exactly you would like to see here?
 > Just that this 1s is here because of mdm uart.

Something like:

 /*
  * Spin waiting for TX fifo to have space available.
  * When using the Microblaze Debug Module this can take up to 1s
  */

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/