Re: [PATCH v2 1/3] regulator: s2mps11: Fix accidental enable of buck6 ramp delay

From: Axel Lin
Date: Tue May 06 2014 - 02:45:47 EST


2014-05-06 14:37 GMT+08:00 Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>:
> S2MPS11 supports enabling/disabling ramp delay only for buck[2346].
> Other bucks have ramp delay enabled always.
>
> However the bit shift for enabling buck6 ramp delay in register is equal
> to 0. When ramp delay was set for the bucks unsupporting enable/disable
> (buck[15789] and buck10), the ramp delay for buck6 was also enabled.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Fixes: b96244fad953 ("regulator: s2mps11: Don't check enable_shift before setting enable ramp rate")

For this serial,
Reviewed-by: Axel Lin <axel.lin@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/